Unit test selection method #10102
Unit test selection method #10102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10102 +/- ##
==========================================
+ Coverage 88.20% 88.21% +0.01%
==========================================
Files 181 181
Lines 22749 22788 +39
==========================================
+ Hits 20066 20103 +37
- Misses 2683 2685 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def test_select_unit_test(manifest: Manifest) -> None: | ||
| test_model = make_model("test", "my_model", "select 1 as id") | ||
| unit_test = make_unit_test("test", "my_unit_test", test_model) | ||
| manifest.unit_tests[unit_test.unique_id] = unit_test |
There was a problem hiding this comment.
Do you feel like this is easier to use or we somehow have a fixture called unittests that will be required by manifest and you return all unittest nodes in it easier? Or maybe not so much difference?
cc @QMalcolm
There was a problem hiding this comment.
I thought this was very easy to use! and keeps unit tests more narrow and isolated from one another in their setup
|
@ChenyuLInx -- I'll do the move here! Should be quick :) |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10102-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43d6c2f369cff8ed888c44c677d0b3468a9186aa
# Push it to GitHub
git push --set-upstream origin backport-10102-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latestThen, create a pull request where the |
(cherry picked from commit 43d6c2f)
resolves: #10053
resolves: #9895
Problem
unit tests could not be passed in using --select
unit_test:*Solution
implement unit test selection method!
Checklist
Some additional 🎩